#541 Check for refresh cookie when JWT_AUTH_HTTPONLY is True #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm 🤔 - failing check doesn't seem to have to do with this change.. looks like the upstream, looking at it. |
|
Nope that was me 🤦 - should be passing now. |
iMerica
approved these changes
Nov 26, 2023
quitterie-lcs
added a commit
to openfun/marsha
that referenced
this pull request
Apr 25, 2024
In `dj-rest-auth` 5.1.0, a conditional check is made on JWT_AUTH_HTTPONLY set to True to check cookies for the refresh token. To avoid this new behavior, JWT_AUTH_HTTPONLY is deactivated. (see iMerica/dj-rest-auth#572)
lunika
pushed a commit
to openfun/marsha
that referenced
this pull request
Jun 4, 2024
In `dj-rest-auth` 5.1.0, a conditional check is made on JWT_AUTH_HTTPONLY set to True to check cookies for the refresh token. To avoid this new behavior, JWT_AUTH_HTTPONLY is deactivated. (see iMerica/dj-rest-auth#572)
lunika
pushed a commit
to openfun/marsha
that referenced
this pull request
Jun 4, 2024
In `dj-rest-auth` 5.1.0, a conditional check is made on JWT_AUTH_HTTPONLY set to True to check cookies for the refresh token. To avoid this new behavior, JWT_AUTH_HTTPONLY is deactivated. (see iMerica/dj-rest-auth#572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditionally checks cookies for the refresh token to blacklist when black list is enabled and
JWT_AUTH_HTTPONLYis true, in order to address errors when attempting to use the/auth/logoutendpoint when both are enabled.This addresses #541