Disable email confirmation ratelimit in tests to support new allauth #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allauth introduced a very restrictive rate limit of 1 email confirmation per 180s in v0.61.0. This doesn't work in the tests.
iMerica
approved these changes
Mar 24, 2024
9128305
reviewed
Apr 2, 2024
| @@ -28,11 +28,11 @@ | |||
| keywords='django rest auth registration rest-framework django-registration api', | |||
| zip_safe=False, | |||
| install_requires=[ | |||
| 'Django>=3.2', | |||
| 'Django>=3.2,<5.0', | |||
There was a problem hiding this comment.
why? I use dj-rest-auth/allauth with django5 with no problems
There was a problem hiding this comment.
@iMerica Why was this change included to require Django<5.0? dj-rest-auth v5.0.2 worked well on Django v5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allauth introduced a very restrictive rate limit of 1 email confirmation per 180s in v0.61.0. This doesn't work in the tests.
As we want to support newer allauth versions, simply disable the ratelimit in the tests.