Fix --dry-run option ignored when set via profile. Fixes cucumber#248.

iafonov · Mar 29, 2012 · 4cc03f1 · 4cc03f1
1 parent 43d30a7
commit 4cc03f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/cucumber/cli/options.rb b/lib/cucumber/cli/options.rb
@@ -375,6 +375,7 @@ def reverse_merge(other_options)
         @options[:source] &= other_options[:source]
         @options[:snippets] &= other_options[:snippets]
         @options[:strict] |= other_options[:strict]
+        @options[:dry_run] |= other_options[:dry_run]
 
         @profiles += other_options.profiles
         @expanded_args += other_options.expanded_args

diff --git a/spec/cucumber/cli/configuration_spec.rb b/spec/cucumber/cli/configuration_spec.rb
@@ -421,6 +421,12 @@ def reset_config
         config.dry_run?.should be_true
       end
 
+      it "returns true when --dry-run was specified in yaml file" do
+        given_cucumber_yml_defined_as({'default' => '--dry-run'})
+        config.parse!([])
+        config.dry_run?.should be_true
+      end
+
       it "returns false by default" do
         config.parse!([])
         config.dry_run?.should be_false