Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalculationMethod.egyptian has wrong fajrAngle and ishaAngle #8

Closed
m-alwakeel opened this issue Feb 15, 2021 · 4 comments · Fixed by #15
Closed

CalculationMethod.egyptian has wrong fajrAngle and ishaAngle #8

m-alwakeel opened this issue Feb 15, 2021 · 4 comments · Fixed by #15

Comments

@m-alwakeel
Copy link

CalculationMethod.egyptian fajrAngle is 20.0 and ishaAngle is 18.0 but they should be 19.5 and 17.5 instead.
@iamriajul
Copy link
Owner

@m-alwakeel where did you find this: 19.5 and 17.5?

@m-alwakeel
Copy link
Author

In your README 😄

SS

@iamriajul
Copy link
Owner

iamriajul commented Feb 16, 2021 •
edited
Loading

Issue related to this: new adjustment for Egyptian fajr angles / batoulapps/adhan-kotlin#14

@iamriajul
Copy link
Owner

PR related to this on adhan-java: batoulapps/adhan-kotlin#29

iamriajul added a commit that referenced this issue Mar 7, 2021
@iamriajul
fix(CalculationMethod): CalculationMethod.egyptian has wrong fajrAngl…
7de7a78 
…e and ishaAngle

batoulapps/adhan-kotlin#29

Closes #8
@iamriajul iamriajul mentioned this issue Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CalculationMethod.egyptian has wrong fajrAngle and ishaAngle iamriajul/adhan-dart
2 participants
@iamriajul @m-alwakeel