Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slate-react) typo - rename extractMatch to exactMatch #4271

Merged

Conversation

omerg
Copy link
Contributor

@omerg omerg commented May 20, 2021

Description
This PR renames one parameter of toSlatePoint to be consistent with the rest of the codebase.
extractMatch parameter is renamed as exactMatch

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2021

🦋 Changeset detected

Latest commit: b39b69c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@omerg omerg changed the title fix typo - rename extractMatch to exactMatch chore(slate-react) typo - rename extractMatch to exactMatch May 20, 2021
Copy link
Collaborator

@juliankrispel juliankrispel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny update to the patch note, otherwise looks good 👍

Copy link
Collaborator

@juliankrispel juliankrispel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@juliankrispel juliankrispel merged commit ff26776 into ianstormtaylor:main May 20, 2021
@github-actions github-actions bot mentioned this pull request May 20, 2021
dylans pushed a commit to dylans/slate that referenced this pull request Sep 13, 2021
…taylor#4271)

* Fix typo - rename extractMatch to exactMatch

* update changelog

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants