Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "Saving to a Database" example to distinguish content changes #4497

Merged
merged 5 commits into from
Sep 26, 2021

Conversation

DougReeder
Copy link
Contributor

Description
As written, the "Saving to a Database" examples save even when the editor content is unchanged. This is inefficient and often undesirable.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

⚠️ No Changeset found

Latest commit: fb47b8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though it needs to match the prettier config (see the suggested changes)... even though I personally prefer semicolons also.

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DougReeder Please run prettier on this and then we can land this change, thanks.

@dylans dylans merged commit 95e13b0 into ianstormtaylor:main Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants