Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

behaviour change between 2.6.0 and 2.6.1 related to empty sub-select warning vs. failure #591

Closed
chris-ratcliffe opened this issue Nov 19, 2019 · 3 comments
Closed

behaviour change between 2.6.0 and 2.6.1 related to empty sub-select warning vs. failure #591

chris-ratcliffe opened this issue Nov 19, 2019 · 3 comments

Comments

@chris-ratcliffe
Copy link

In version 2.6.0 and previous versions, running a statement like the following:

DELETE FROM TABLEA 
WHERE CATEGORY_ID IN 
  ( SELECT CATEGORY_ID FROM TABLEB B, TABLEC C 
    WHERE B.CATEGORY_ID=C.ID AND B.SURVEY_ID=? AND \"GROUP\"=?
  ) 
AND SURVEY_ID=?"

would work fine, even if the sub-select returned an empty set. However, starting in 2.6.1, the statement is failing when run with the executeNonQuery() function, such that the err argument is non-null in the callback function. The SQL error being returned is sql100w , which is not really an error at all, and simply an indication that the fetch was empty. But again, starting in the latest version, its now causing the error path to be executed in the callback.
bimalkjha added a commit that referenced this issue Nov 20, 2019
@bimalkjha
fix: ignore sqlcode 100 by executeNonQuery, issue #591
37bd232
@bimalkjha
Copy link
Member

@chris-ratcliffe Please pull the latest code from github and verify. We have delivered fix for this issue, hence closing it. Thanks.

@chris-ratcliffe
Copy link
Author

@bimalkjha , I tend to install using npm. Will there a 2.6.2 release available with the fix?

bimalkjha added a commit that referenced this issue Dec 3, 2019
@bimalkjha
Merging vscode branch at latest code level. (#596)
1f580e5 
* doc: Docker Linux Container instructions

* support for install --debug option on windows

* fix: blob data corruption issue #582

* doc: update doc for executeNonQuerySync API, issue #583

* force push connection to the queue when poolSize breaches maxPool boundry (#581)

* Support for node v12 on z/OS, and fix some test cases for z/OS (#586)

* fix: update unzipper version, issue #588

* fix: use v8::Isolate for nodev >= 11

* fix: ignore sqlcode 100 by executeNonQuery, issue #591

* fix: add executeNonQuerySync in odbc.js issue #595
bimalkjha added a commit that referenced this issue Dec 9, 2019
@bimalkjha
2.6.2
ead9b81 
 * doc: update for issue #593 (Bimal Jha)
 * fix: update windows binary using latest code (Bimal Jha)
 * fix: for memory leak issue #576 (Bimal Jha)
 * fix: update windows binary for vscode 1.40.x (Bimal Jha)
 * update windows binaries (Bimal Jha)
 * fix: add executeNonQuerySync in odbc.js issue #595 (Bimal Jha)
 * fix: ignore sqlcode 100 by executeNonQuery, issue #591 (Bimal Jha)
 * fix: use v8::Isolate for nodev >= 11 (Bimal Jha)
 * fix: update unzipper version, issue #588 (Bimal Jha)
 * Support for node v12 on z/OS, and fix some test cases for z/OS (#586) (alexcfyung)
 * force push connection to the queue when poolSize breaches maxPool boundry (#581) (ashutoshrnjn)
 * doc: update doc for executeNonQuerySync API, issue #583 (Bimal Jha)
 * fix: blob data corruption issue #582 (Bimal Jha)
 * support for install --debug option on windows (Priyanka Manoharan)
 * doc: Docker Linux Container instructions (Bimal Jha)
@bimalkjha
Copy link
Member

@chris-ratcliffe You can install [email protected]. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris-ratcliffe @bimalkjha