Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/angle snapping fix #263

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Jul 1, 2022

A nicer implementation of angle snapping

@andybak andybak requested review from mikeskydev and mikeage July 3, 2022 10:03
Copy link
Member

@mikeskydev mikeskydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting what I can only describe as 'gimbal lock' at the north and south poles when attempting to rotate the selected item. It's not as intuitive as the previous implementation.

2022-07-04.15-49-24.webm

@andybak
Copy link
Contributor Author

andybak commented Jul 4, 2022

I think it's just "different bad" - if you'd tried to use the previous implementation in any depth you would have found other serious problems. I hadn't tried rotating at the poles however. I'll take a look.

@andybak
Copy link
Contributor Author

andybak commented Jul 5, 2022

I think it's just "different bad" - if you'd tried to use the previous implementation in any depth you would have found other serious problems. I hadn't tried rotating at the poles however. I'll take a look.

Actually - now I've tried it, I can confirm there's something weird going on aside from behaviour at the poles.

Investigating.

@andybak
Copy link
Contributor Author

andybak commented Jul 5, 2022

Sigh. I have no idea how to resolve this. I do know the current bahaviour is bad. Try creating multiple copies of a brush stroke arrayed around a center point with an angle snap of 45 degrees.

This commit kinda fixes that but with some fairly unintuitive side-effects. The cure is worse than the disease in this case but the underlying problem still remains.

I hate rotation.

@andybak
Copy link
Contributor Author

andybak commented Jul 5, 2022

@moatdd - any thoughts?

@andybak andybak marked this pull request as draft August 4, 2022 09:40
@mikeskydev mikeskydev added the bugfix Something has been fixed label Aug 9, 2022
@mikeskydev mikeskydev added this to the Post 2.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants