-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/angle snapping fix #263
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting what I can only describe as 'gimbal lock' at the north and south poles when attempting to rotate the selected item. It's not as intuitive as the previous implementation.
2022-07-04.15-49-24.webm
I think it's just "different bad" - if you'd tried to use the previous implementation in any depth you would have found other serious problems. I hadn't tried rotating at the poles however. I'll take a look. |
Actually - now I've tried it, I can confirm there's something weird going on aside from behaviour at the poles. Investigating. |
Sigh. I have no idea how to resolve this. I do know the current bahaviour is bad. Try creating multiple copies of a brush stroke arrayed around a center point with an angle snap of 45 degrees. This commit kinda fixes that but with some fairly unintuitive side-effects. The cure is worse than the disease in this case but the underlying problem still remains. I hate rotation. |
@moatdd - any thoughts? |
A nicer implementation of angle snapping