-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Judge capabilities #145
base: master
Are you sure you want to change the base?
Judge capabilities #145
Conversation
Contest_API.md
Outdated
All requests must include a valid JSON object with the same properties as the commentary | ||
endpoint returns from a `GET` request with the following exceptions: | ||
|
||
- The `judge\_comment` capability only has access to `POST`. `id`, `time`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: since no PUT
is defined, this is not really necessary. But I'm fine with leaving it in, for in case we add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was copied from similar capabilities, will try to improve as part of a rewrite.
team_clar has been changed to a generic post_clar, and a post_comment capability with access equivalent to what a judge/analyst should be able to do has been added, and described similar to other capabilities.
All requests must include a valid JSON object with the same properties as the commentary | ||
endpoint returns from a `GET` request with the following exceptions: | ||
|
||
- The `post\_comment` capability only has access to `POST`. `id`, `time`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this first sentence should be removed. In the clarifications endpoint it made sense since there was also a {proxy,admin}_clar
capability with PUT access, but here there is only POST.
- The `post\_comment` capability only has access to `POST`. `id`, `time`, | |
- `id`, `time`, |
Co-authored-by: Jaap Eldering <[email protected]>
@deboer-tim What is the status of this? Can we close? |
Discuss on the next call? This is implemented on the CDS and is required API support for clients to submit commentary - but I'm not aware of anyone else looking at / implementing this so not sure if it's worth spec or should just be a CDS-specific extension for now. |
Edited:
team_clar has been changed to a generic post_clar, and a post_comment capability with access equivalent to what a judge/analyst should be able to do has been added, and described similar to other capabilities.