Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judge capabilities #145

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Judge capabilities #145

wants to merge 2 commits into from

Conversation

deboer-tim
Copy link
Member

@deboer-tim deboer-tim commented Apr 11, 2023

Edited:
team_clar has been changed to a generic post_clar, and a post_comment capability with access equivalent to what a judge/analyst should be able to do has been added, and described similar to other capabilities.

nickygerritsen
nickygerritsen previously approved these changes Apr 12, 2023
Contest_API.md Outdated Show resolved Hide resolved
Contest_API.md Outdated Show resolved Hide resolved
Contest_API.md Outdated
All requests must include a valid JSON object with the same properties as the commentary
endpoint returns from a `GET` request with the following exceptions:

- The `judge\_comment` capability only has access to `POST`. `id`, `time`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: since no PUT is defined, this is not really necessary. But I'm fine with leaving it in, for in case we add that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from similar capabilities, will try to improve as part of a rewrite.

@nickygerritsen nickygerritsen marked this pull request as draft June 12, 2023 18:14
team_clar has been changed to a generic post_clar, and a post_comment capability with access equivalent to what a judge/analyst should be able to do has been added, and described similar to other capabilities.
Contest_API.md Outdated Show resolved Hide resolved
All requests must include a valid JSON object with the same properties as the commentary
endpoint returns from a `GET` request with the following exceptions:

- The `post\_comment` capability only has access to `POST`. `id`, `time`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this first sentence should be removed. In the clarifications endpoint it made sense since there was also a {proxy,admin}_clar capability with PUT access, but here there is only POST.

Suggested change
- The `post\_comment` capability only has access to `POST`. `id`, `time`,
- `id`, `time`,

Co-authored-by: Jaap Eldering <[email protected]>
@niemela
Copy link
Member

niemela commented Nov 28, 2024

@deboer-tim What is the status of this? Can we close?

@deboer-tim
Copy link
Member Author

Discuss on the next call? This is implemented on the CDS and is required API support for clients to submit commentary - but I'm not aware of anyone else looking at / implementing this so not sure if it's worth spec or should just be a CDS-specific extension for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants