Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh support #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add zh support #35

wants to merge 3 commits into from

Conversation

yyt030
Copy link

@yyt030 yyt030 commented Jul 15, 2023

RT

@corpix
Copy link
Collaborator

corpix commented Jul 21, 2023

Thanks for your contribution!
I see you have regenerated data.go and for some reason there is a carriage return appeared:

Old version:

 ~  λ  echo H4sIAAAJbogA/wzKQarCUAwF0Pnd1f+CRUQsUgSHoe9SQ9PEpka3b0dncm5s+LciuiQdD5rFF9cUn4i+8mXEXcP4xsmbToGBYujVZxxrG1XQhTV6RsNF6oO/tWSRVCeGyrVCN+KQumzh+8jY6Wskzk+Z9RcAAP///hYIpoAAAAA= | base64 -d | gunzip | hexdump -C
00000000  52 65 64 0a 42 6c 75 65  0a 47 72 65 65 6e 0a 59  |Red.Blue.Green.Y|
00000010  65 6c 6c 6f 77 0a 4f 72  61 6e 67 65 0a 50 75 72  |ellow.Orange.Pur|
00000020  70 6c 65 0a 56 69 6f 6c  65 74 0a 49 6e 64 69 67  |ple.Violet.Indig|
00000030  6f 0a 54 65 61 6c 0a 50  69 6e 6b 0a 46 75 73 63  |o.Teal.Pink.Fusc|
00000040  69 61 0a 47 6f 6c 64 65  6e 72 6f 64 0a 4d 61 75  |ia.Goldenrod.Mau|
00000050  76 0a 41 71 75 61 6d 61  72 69 6e 65 0a 54 75 72  |v.Aquamarine.Tur|
00000060  71 75 6f 69 73 65 0a 43  72 69 6d 73 6f 6e 0a 4d  |quoise.Crimson.M|
00000070  61 72 6f 6f 6e 0a 50 75  63 65 0a 4b 68 61 6b 69  |aroon.Puce.Khaki|
00000080 

New version:

 ~  λ  echo H4sIAAAAAAAC/xTKwarCQAwF0P2F+1HvCRYRsUgRXA6dUEOniU2N/r50dTbnJpX4bylEFyJGPKQ1/xLXKDYJ0We8mhB39SZv4mRVJycGKY3o1WbimNuohei8VbHwSlxKfoi/NctSQk2IIWNN102IQ+iyue0rfLfPUYjzs8z6CwAA//97rU8+kgAAAA== | base64 -d | gunzip | hexdump -C
00000000  52 65 64 0d 0a 42 6c 75  65 0d 0a 47 72 65 65 6e  |Red..Blue..Green|
00000010  0d 0a 59 65 6c 6c 6f 77  0d 0a 4f 72 61 6e 67 65  |..Yellow..Orange|
00000020  0d 0a 50 75 72 70 6c 65  0d 0a 56 69 6f 6c 65 74  |..Purple..Violet|
00000030  0d 0a 49 6e 64 69 67 6f  0d 0a 54 65 61 6c 0d 0a  |..Indigo..Teal..|
00000040  50 69 6e 6b 0d 0a 46 75  73 63 69 61 0d 0a 47 6f  |Pink..Fuscia..Go|
00000050  6c 64 65 6e 72 6f 64 0d  0a 4d 61 75 76 0d 0a 41  |ldenrod..Mauv..A|
00000060  71 75 61 6d 61 72 69 6e  65 0d 0a 54 75 72 71 75  |quamarine..Turqu|
00000070  6f 69 73 65 0d 0a 43 72  69 6d 73 6f 6e 0d 0a 4d  |oise..Crimson..M|
00000080  61 72 6f 6f 6e 0d 0a 50  75 63 65 0d 0a 4b 68 61  |aroon..Puce..Kha|
00000090  6b 69                                             |ki|
00000092

Line breaks was 0a, become 0d 0a. Not sure it is good thing to have for everyone, may break something. Could you please fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants