-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli support for generating solution for multiple projects #2364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwie
changed the title
Cli/support sln gen
Cli/support for generating solution for multiple projects
Apr 3, 2021
marwie
changed the title
Cli/support for generating solution for multiple projects
Cli support for generating solution for multiple projects
Apr 3, 2021
…-gen # Conflicts: # ICSharpCode.Decompiler.Console/IlspyCmdProgram.cs
siegfriedpammer
added a commit
that referenced
this pull request
Apr 15, 2022
05eb2cd implements this feature by migrating your code to ILSpy 8.0. ilspycmd now accepts multiple assembly file names. If more than one filename and the "-p" option is given, a solution file is automatically generated in the root output directory. For every project a sub-directory is created and the project file and source files are placed within. Sorry for taking so long to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers
#2363
#1550
Problem
Commandline interface does not expose a feature to compile multiple assemblies into a solution
Prefix
This PR should be considered as a possible basic solution that I need feedback on to properly fix/implement :)
Solution
I added support to use multiple dll files as
InputAssemblyName
arg (used like thisilspycmd "lib1.dll lib2.dll" <other arguments>
)And provided with a output solution path as
--sln
it would callWriteSolutionFile
as implemented in #2363But generally speaking I'm not sure if this is the correct approach to decompile multiple assemblies/projects. For example when decompiling both UnityEditor.dll and UnityEngine.dll to the same output path both projects would contain the same files (as everything is in one directory)
So the problem for that is is that the output path for an assembly must be empty/multiple projects must be output to separate output directories, maybe implicitly generated in the output directory from the dll names?
Alternative ideas
Another idea would be to provide an --sln argument to multiple generated
.csproj
files which then would invoke theWriteSolutionFile
call. But this would require to collect the necessary meta information from previous compiled/the csproj(?)which currently is
string projectFile, string projectPlatform, Guid projectGuid, Guid typeGuid
.Would be interested to hear what you think/prefer and/or if there are better solutions already or in process?! :)