Add progress reporting to PortablePdbWriter #2802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in #2801, the Visual Studio debugger would like to be able to provide better progress feedback to users while a decompilation operation is in progress.
Solution
This commit adds a new parameter to
PortablePdbWriter.WritePdb
that allows the caller to provide an implementation ofIProgress<>
to receive status updates on the pdb generation process. Currently, the progress reports include the number of files generated so far and the total number of files.#2801 mentions adding progress reporting to
WholeProjectDecompiler
as well, but that appears to already be present - see: https://github.com/icsharpcode/ILSpy/blob/master/ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs#L256