Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Derived Types Node always being empty #3280

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Applesauce314
Copy link
Contributor

it appears Fix #3263 added an accidental != instead of == and broke the derived types node.

no issue exists, but i can create one if desired

Problem

Derived type nodes where always empty with a build from latest version. Traced it to what appears to be a backwards null check != null vs == null.

Solution

  • Corrected the comparison, derived types tab is now populated
  • need someone to verify the original issue in ILSpy crash #3263 is still fixed by the resultant code. (I would expect it to be, but don't know how to check myself)
  • At least one test covering the code changed

it appears Fix icsharpcode#3263 added an accidental `!=` instead of `==` and broke the derived types node.
@siegfriedpammer
Copy link
Member

  • need someone to verify the original issue in ILSpy crash #3263 is still fixed by the resultant code. (I would expect it to be, but don't know how to check myself)

Yes, your fix is fine. Thanks for providing a PR.

@siegfriedpammer siegfriedpammer merged commit 5e7e677 into icsharpcode:master Sep 20, 2024
5 checks passed
@Applesauce314 Applesauce314 mentioned this pull request Sep 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILSpy crash
2 participants