Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update setup and modernize a bit #59

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jan 2, 2021

See #58. This is the "deluxe" package mentioned there. You could do a smaller set of changes, including just adding wheel to your environment and python setup.py bdist_wheel —universal. This includes:

  • Add setup.cfg to always make a universal wheel (Python 2 + 3)
  • Add pyproject.toml to support PEP 517 builds
  • Update docs on how to build using PyPA build (still can build classically as well, of course)
  • Update setup.py for best practices (including missing python_requires, and proper environment markers for install_requires)
  • Replace nose (abandoned since 2015) with pytest (which can run nose tests)
  • Minor fix for Python 3 incompatible syntax

Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Note that nose is no longer maintained and will no longer be compatible with Python 3.10, due for release in 2 weeks.

So this PR replacing nose with pytest is especially timely!

@idank
Copy link
Owner

idank commented Sep 23, 2021

Sorry for the delay on this, appreciate the contribution! And thanks for reviewing @hugovk.

@idank idank merged commit a82fc5f into idank:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants