-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initialisation freezing on empty primary data. #1016
base: dev
Are you sure you want to change the base?
Fix initialisation freezing on empty primary data. #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adapted the code a tiny bit. Would be great to have tests for this as well, though, I think.
Thank you for taking care of this! One point to discuss, based on the data in |
That's a neat idea, however this sounds more complicated and could rather be handled in a new PR? For now I'm quite happy that there's an error message at all |
Fair point. Yes we should handle that in a new PR |
Resolves #981