Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unapply method for ThermalHouseResults #935

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Add unapply method for ThermalHouseResults #935

wants to merge 15 commits into from
+53 −3

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Aug 24, 2024 •
edited
Loading

resolves #934

required for #879

@danielfeismann danielfeismann self-assigned this Aug 24, 2024
@danielfeismann danielfeismann added bug Something isn't working enhancement New feature or request labels Aug 24, 2024
@danielfeismann danielfeismann mentioned this pull request Nov 5, 2024
Draft
@danielfeismann danielfeismann marked this pull request as ready for review November 5, 2024 12:57
staudtMarius
staudtMarius requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I found two parts that could be improved.

src/main/scala/edu/ie3/simona/event/ResultEvent.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/event/ResultEvent.scala Show resolved Hide resolved
sebastian-peter
sebastian-peter requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Just some minor code formatting points.

src/main/scala/edu/ie3/simona/event/ResultEvent.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/event/ResultEvent.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/event/ResultEvent.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius requested changes

@sebastian-peter sebastian-peter sebastian-peter requested changes

@jo-bao jo-bao Awaiting requested review from jo-bao

Requested changes must be addressed to merge this pull request.

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unapply method for ThermalHouseResults
3 participants
@danielfeismann @sebastian-peter @staudtMarius