Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNS nits #1178

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix DNS nits #1178

merged 1 commit into from
Jun 5, 2023

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Jun 4, 2023

Closes #1177

@tfpauly tfpauly requested review from britram, mwelzl and abrunstrom June 4, 2023 01:32
@tfpauly tfpauly self-assigned this Jun 4, 2023
mwelzl
mwelzl approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

abrunstrom
abrunstrom approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@abrunstrom abrunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tfpauly tfpauly merged commit 3ff7c23 into master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwelzl mwelzl mwelzl approved these changes

@abrunstrom abrunstrom abrunstrom approved these changes

@britram britram Awaiting requested review from britram

Assignees

@tfpauly tfpauly

Labels
Implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS nits
3 participants
@tfpauly @mwelzl @abrunstrom