-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FQDN endpoint identifyer #1464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ABSTAIN":
I see, this implements a comment you added to a previous PR.
Is this an improvement or not? I'm not sure - on the one hand, it makes the API bigger, but on the other, it makes the dangers of not using an FQDN somewhat more explicit. That's a bit like our decision to have an "InitiateWithSend" call as opposed to adding a "data" parameter to "Initiate".
There's a design trade-off here, and I'm undecided about what is better.
Also, I'm not sure it's a good idea to make such a change that late in the process.
- FQDN (string containing a Fully Qualified Domain Name): | ||
|
||
~~~ | ||
RemoteSpecifier.FQDN("example.com") | ||
~~~ | ||
|
||
- HostName (string that gets qualified while resolving, e.g., using DNS search domains): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- FQDN (string containing a Fully Qualified Domain Name): | |
~~~ | |
RemoteSpecifier.FQDN("example.com") | |
~~~ | |
- HostName (string that gets qualified while resolving, e.g., using DNS search domains): | |
- HostName (a string, which SHOULD be a Fully Qualified Domain Name): |
Applications creating Endpoint objects using `WithHostName` should consider using fully-qualified | ||
domain names (FQDNs) instead. Not providing an FQDN will result in the Transport Services Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applications creating Endpoint objects using `WithHostName` should consider using fully-qualified | |
domain names (FQDNs) instead. Not providing an FQDN will result in the Transport Services Implementation | |
Applications creating Endpoint objects using `WithHostName` SHOULD provide fully-qualified | |
domain names (FQDNs). Not providing an FQDN will result in the Transport Services Implementation |
Can we close this? I think the consensus was that it would only be ok to do with the changes suggested by @tfpauly , but then this does not really add any extra functionality since names are already specified to be FQDN's with a SHOULD. |
I think this is fine to close |
With the changes discussed, it does not really add any value but adds changes to the next review phase |
Add an option to distinguish FQDNs from unqualified HostNames to address concerns from #1460