V2 #7
Merged
V2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def update_connection(connection_id, body) | ||
| fail Auth0::MissingConnectionId, 'you must specify a connection id' if connection_id.to_s.empty? | ||
| fail Auth0::InvalidParameter, 'Must supply a valid connection id' if connection_id.to_s.empty? |
There was a problem hiding this comment.
This format does not match on all validations for the rest of the endpoints. What form should we use: "you must..." or "Must..."?
There was a problem hiding this comment.
Most of the errors are 'Must....;, so we'll keep this one, but we should change it in clients.rb
Change email path variable name
| def create_client(name, options = {}) | ||
| fail Auth0::MissingParameter, 'you must specify a valid client name' if name.to_s.empty? |
There was a problem hiding this comment.
This should be 'Must...' and all the message in this class too.
There was a problem hiding this comment.
BTW, we should also update the tests.
| def patch_user(user_id, options) | ||
| fail Auth0::MissingUserId, 'Must supply a valid user_id' if user_id.to_s.empty? | ||
| fail Auth0::InvalidParameter, 'Must supply a valid body' if options.to_s.empty? |
There was a problem hiding this comment.
Message says Must supply body and parameter is options. Is this message set by requirement?
|
All feedback applied. Merging. |
ignaciojonas
added a commit
that referenced
this pull request
Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.