Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trust_threshold is not aligned for latest hermes #164

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 7, 2025

@Pantani
Copy link
Collaborator

Pantani commented Feb 7, 2025

@mmsqe, thanks for the report. However, the issue with the thrust threshold is that the relayer apps are not getting the default values from app flags, which was solved here. If you set it as a flag, it will work

@mmsqe
Copy link
Contributor Author

mmsqe commented Feb 7, 2025

ue with the thrust threshold is that the relayer apps are not getting the default values from app flags

Do you mean the default was {denominator = '0', numerator = '0'} instead of {denominator = '3', numerator = '2'}? but seems cli is also using v1.10.5 instead of the format for v1.7.4

@Pantani Pantani changed the title Problem: trust_threshold is not aligned for latest hermes fix: trust_threshold is not aligned for latest hermes Feb 12, 2025
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmsqe you are right, Thanks for catching the issue

@Pantani Pantani merged commit ff8cd6e into ignite:main Feb 12, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants