Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update apps to use gRPC #11

Merged
merged 3 commits into from
Nov 13, 2023
Merged

refactor: update apps to use gRPC #11

merged 3 commits into from
Nov 13, 2023

Conversation

jeronimoalbi
Copy link
Member

Requires ignite/cli#3529 to be merged first.

@jeronimoalbi jeronimoalbi self-assigned this Oct 25, 2023
@jeronimoalbi jeronimoalbi marked this pull request as ready for review November 11, 2023 13:56
julienrbrt
julienrbrt reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeronimoalbi jeronimoalbi merged commit 5d6084f into main Nov 13, 2023
4 checks passed
@julienrbrt julienrbrt deleted the feat/grpc-protocol branch November 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@tbruyelle tbruyelle Awaiting requested review from tbruyelle tbruyelle is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeronimoalbi @julienrbrt