fix(chain): fix issue in release ci and command (backport #4474) (#4475)

* fix(chain): fix issue in release ci and command (#4474) * fix(chain): fix issue in release ci and command * updates (cherry picked from commit a0ac845) # Conflicts: # ignite/pkg/archive/tar_gz.go # ignite/services/chain/build.go * conflicts --------- Co-authored-by: Julien Robert <[email protected]>
ignite · Jan 17, 2025 · 538870f · 538870f
1 parent c902195
commit 538870f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/changelog.md b/changelog.md
@@ -8,6 +8,10 @@
 - [#4471](https://github.com/ignite/cli/pull/4471) Bump CometBFT to v0.38.15.
 - [#4471](https://github.com/ignite/cli/pull/4471) Bump Ignite & chain minimum Go version to 1.23.
 
+### Bug Fixes
+
+- [#4474](https://github.com/ignite/cli/pull/4474) Fix issue in `build --release` command
+
 ## [`v28.7.0`](https://github.com/ignite/cli/releases/tag/v28.7.0)
 
 ### Features

diff --git a/ignite/pkg/archive/tar_gz.go b/ignite/pkg/archive/tar_gz.go
@@ -41,6 +41,19 @@ func addToArchive(tw *tar.Writer, filename string) error {
 	}
 
 	// Create a tar Header from the FileInfo data
+	if info.IsDir() {
+		hdr, err := tar.FileInfoHeader(info, info.Name())
+		if err != nil {
+			return err
+		}
+		hdr.Name = filename
+		if err := tw.WriteHeader(hdr); err != nil {
+			return err
+		}
+
+		return nil
+	}
+
 	header, err := tar.FileInfoHeader(info, info.Name())
 	if err != nil {
 		return err

diff --git a/ignite/services/chain/build.go b/ignite/services/chain/build.go
@@ -189,7 +189,7 @@ func (c *Chain) BuildRelease(
 		defer tarf.Close()
 
 		if err := archive.CreateArchive(out, tarf); err != nil {
-			return "", err
+			return "", errors.Errorf("error creating release archive: %w", err)
 		}
 	}
 

diff --git a/ignite/templates/app/files/.github/workflows/release.yml b/ignite/templates/app/files/.github/workflows/release.yml
@@ -34,6 +34,7 @@ jobs:
           args: chain build --release --release.prefix ${{ steps.vars.outputs.tarball_prefix }} -t linux:amd64 -t darwin:amd64 -t darwin:arm64 -y
         env:
           DO_NOT_TRACK: 1
+          GOFLAGS: "-buildvcs=false"
 
       - name: Delete the "latest" Release
         uses: dev-drprasad/[email protected]