fix(network): out of gas issue when approving many request (#3114)

* add gas auto * comment * use constant * changelog * minor lint fix Co-authored-by: aljo242 <[email protected]>
ignite · Nov 18, 2022 · 552b25f · 552b25f
1 parent 73124ac
commit 552b25f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -43,7 +43,7 @@
 
 ### Fixes
 
-
+- [#3114](https://github.com/ignite/cli/pull/3114) Fix out of gas issue when approving many requests
 - [#3068](https://github.com/ignite/cli/pull/3068) Fix REST codegen method casing bug
 - [#3031](https://github.com/ignite/cli/pull/3031) Move keeper hooks to after all keepers initialized in `app.go`
   template.

diff --git a/ignite/cmd/network.go b/ignite/cmd/network.go
@@ -205,6 +205,7 @@ func getNetworkCosmosClient(cmd *cobra.Command) (cosmosclient.Client, error) {
 		cosmosclient.WithUseFaucet(spnFaucetAddress, networktypes.SPNDenom, 5),
 		cosmosclient.WithKeyringServiceName(cosmosaccount.KeyringServiceName),
 		cosmosclient.WithKeyringDir(getKeyringDir(cmd)),
+		cosmosclient.WithGas(cosmosclient.GasAuto),
 	}
 
 	keyringBackend := getKeyringBackend(cmd)

diff --git a/ignite/pkg/cosmosclient/cosmosclient.go b/ignite/pkg/cosmosclient/cosmosclient.go
@@ -52,6 +52,9 @@ var (
 )
 
 const (
+	// GasAuto allows to calculate gas automatically when sending transaction
+	GasAuto = "auto"
+
 	defaultNodeAddress   = "http://localhost:26657"
 	defaultGasAdjustment = 1.0
 	defaultGasLimit      = 300000
@@ -560,7 +563,7 @@ func (c Client) CreateTx(goCtx context.Context, account cosmosaccount.Account, m
 	}
 
 	var gas uint64
-	if c.gas != "" && c.gas != "auto" {
+	if c.gas != "" && c.gas != GasAuto {
 		gas, err = strconv.ParseUint(c.gas, 10, 64)
 		if err != nil {
 			return TxService{}, errors.WithStack(err)
@@ -571,7 +574,7 @@ func (c Client) CreateTx(goCtx context.Context, account cosmosaccount.Account, m
 			return TxService{}, errors.WithStack(err)
 		}
 		// the simulated gas can vary from the actual gas needed for a real transaction
-		// we add an additional amount to ensure sufficient gas is provided
+		// we add an amount to ensure sufficient gas is provided
 		gas += 20000
 	}
 	txf = txf.WithGas(gas)