Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colon syntax from --dep #3030

Closed
Tracked by #3051
fadeev opened this issue Nov 1, 2022 · 1 comment · Fixed by #3047
Closed
Tracked by #3051

Remove colon syntax from --dep #3030

fadeev opened this issue Nov 1, 2022 · 1 comment · Fixed by #3047
Assignees
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding.

Comments

@fadeev
Copy link
Contributor

fadeev commented Nov 1, 2022

Currently, to scaffold a module with a dependency on another module you have to do the following:

ignite scaffold module foo --dep bank

This works for bank, but doesn't for feegrant, because it's it's trying to find FeegrantKeeper and fails. What it needs is FeeGrantKeeper (notice the G). Ignite has an ugly solution that works:

ignite scaffold module foo --dep feegrant:FeeGrantKeeper

I propose we remove the colon syntax for --dep and ask users to provide dependencies in a capitalized form (--dep FeeGrant). We can also capitalize the first letter for convenience, so --dep bank would also work (but --dep feegrant wouldn't).

Context: #2776

@fadeev fadeev added the component:scaffold Feature, enhancement, or refactor related to scaffolding. label Nov 1, 2022
@jeronimoalbi jeronimoalbi self-assigned this Nov 3, 2022
@jeronimoalbi
Copy link
Member

I still have the feeling it's not quite user friendly as the possible formats are not instantly clear. I added FeeGrant to the flag help because of that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants