-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove colon syntax from module scaffolding --dep
flag
#3047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
- ignite s module foo --dep bank,FeeGrant
- ignite c serve
works like a charm
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! is there some documentation that needs to be updated for this? Maybe a tutorial? We can update here, or merge after opening a new docs issue (only if necessary).
@fadeev do you know if the colon syntax is documented somewhere? I can't find any reference, usage or example, so it seems that the colon syntax was a hidden feature :) |
@jeronimoalbi no, I submitted a pr to add docs, but then proposed to actually change the behavior instead. |
@aljo242 I we don't really need to update the documentation because the colon syntax was not documented. We could improve the current one, I guess, but right now I'm not entirely sure how. |
…e#3047) Co-authored-by: Alex Johnson <[email protected]>
Resolves #3030