Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove colon syntax from module scaffolding --dep flag #3047

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

jeronimoalbi
Copy link
Member

Resolves #3030

tbruyelle
tbruyelle previously approved these changes Nov 3, 2022
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

  • ignite s module foo --dep bank,FeeGrant
  • ignite c serve
    works like a charm

LGTM

Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! is there some documentation that needs to be updated for this? Maybe a tutorial? We can update here, or merge after opening a new docs issue (only if necessary).

@jeronimoalbi
Copy link
Member Author

@fadeev do you know if the colon syntax is documented somewhere? I can't find any reference, usage or example, so it seems that the colon syntax was a hidden feature :)

@fadeev
Copy link
Contributor

fadeev commented Nov 3, 2022

@jeronimoalbi no, I submitted a pr to add docs, but then proposed to actually change the behavior instead.

@jeronimoalbi
Copy link
Member Author

lgtm! is there some documentation that needs to be updated for this? Maybe a tutorial? We can update here, or merge after opening a new docs issue (only if necessary).

@aljo242 I we don't really need to update the documentation because the colon syntax was not documented. We could improve the current one, I guess, but right now I'm not entirely sure how.

aljo242
aljo242 previously approved these changes Nov 3, 2022
@aljo242 aljo242 dismissed stale reviews from tbruyelle and themself via 0fc0c25 November 4, 2022 13:03
@aljo242 aljo242 merged commit b51837d into develop Nov 4, 2022
@aljo242 aljo242 deleted the feat/remove-dep-flag-colon-syntax branch November 4, 2022 14:41
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove colon syntax from --dep
4 participants