Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add network add-account command #2955

Merged
merged 17 commits into from
Oct 20, 2022
Merged

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Oct 19, 2022

ignite network request add-account [launch-id] [address] [coins] [flags]

Allows to send a request to be an account in a chain genesis (or add an account directly for coordinator)

ignite n request add-account 44 spn1pe5h2gelhu8aukmrnj0clmec56aspxzuxcy99y 1000bar

If a chain has been published with the AccountBalance option, no coins value is expected

ignite n chain publish https://github.com/ignite/example --account-balance 5000foo

ignite n request add-account 45 spn1pe5h2gelhu8aukmrnj0clmec56aspxzuxcy99y 50bar --from alice
Source code fetched
Blockchain set up
balance can't be provided, balance has been set by coordinator to 5000foo

ignite n request add-account 45 spn1pe5h2gelhu8aukmrnj0clmec56aspxzuxcy99y --from alice
Source code fetched
Blockchain set up
Request 1 to add account to the network has been submitted!

ignite n request list 45
Id 	Status 		Type 			Content
1 	PENDING 	Add Genesis Account 	spn1pe5h2gelhu8aukmrnj0clmec56aspxzuxcy99y, 5000foo

@lumtis lumtis linked an issue Oct 19, 2022 that may be closed by this pull request
@lumtis lumtis requested a review from jeronimoalbi October 20, 2022 14:16
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
jeronimoalbi
jeronimoalbi previously approved these changes Oct 20, 2022
Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments but LGTM though 👍

tbruyelle
tbruyelle previously approved these changes Oct 20, 2022
tbruyelle
tbruyelle previously approved these changes Oct 20, 2022
@lumtis lumtis requested a review from tbruyelle October 20, 2022 16:58
@lumtis lumtis merged commit 25361b3 into develop Oct 20, 2022
@lumtis lumtis deleted the feat/network-add-account branch October 20, 2022 18:29
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* refactor service

* command

* add command

* improve error

* changelog

* Update ignite/services/network/join.go

Co-authored-by: Jerónimo Albi <[email protected]>

* remove unused

* changelog

* import

* Update ignite/cmd/network_request_add_account.go

Co-authored-by: Jerónimo Albi <[email protected]>

* Update changelog.md

Co-authored-by: Alex Johnson <[email protected]>

* Update ignite/cmd/network_request_add_account.go

Co-authored-by: Thomas Bruyelle <[email protected]>

* revert command

Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Thomas Bruyelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a command for adding genesis accounts
4 participants