-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network
): add network add-account
command
#2955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
ilgooz,
jeronimoalbi,
aljo242,
tbruyelle and
fadeev
as code owners
October 19, 2022 23:37
aljo242
reviewed
Oct 20, 2022
jeronimoalbi
previously approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments but LGTM though 👍
tbruyelle
reviewed
Oct 20, 2022
tbruyelle
previously approved these changes
Oct 20, 2022
Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Thomas Bruyelle <[email protected]>
tbruyelle
previously approved these changes
Oct 20, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* refactor service * command * add command * improve error * changelog * Update ignite/services/network/join.go Co-authored-by: Jerónimo Albi <[email protected]> * remove unused * changelog * import * Update ignite/cmd/network_request_add_account.go Co-authored-by: Jerónimo Albi <[email protected]> * Update changelog.md Co-authored-by: Alex Johnson <[email protected]> * Update ignite/cmd/network_request_add_account.go Co-authored-by: Thomas Bruyelle <[email protected]> * revert command Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to send a request to be an account in a chain genesis (or add an account directly for coordinator)
If a chain has been published with the
AccountBalance
option, nocoins
value is expected