-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Addition of plugin docs #3066
Conversation
Great addition, thank you Josh! |
Updated docs per @tbruyelle comments. Changes structure to have two primary categories
|
Seeing that the deployment action is throwing an error relating to firebase credentials:
|
I don't know why, maybe it's because the PR is originated from an external repo ? |
I think so, I can move it over to a branch from this repository. |
@joshLong145 I'm working on a change to adapt the documentation with the latest changes of #3060, can you enable Allow edits from maintainers again please ? |
sure thing, I attempted to migrate the changes to their own branch off this repo but I don't have write access to the repository it seems. |
Thank you, I pushed the change. So the main changes are :
Concerning the doc, I revamped a little bit because we must mention |
should we migrate this to a branch directly off ignite to get deployment actions passing or just leave it how it is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I participated to this PR, it must have a second approval :)
* addition of plugin docs * updates to new plugin docs * docs: update according to last interface changes * remove private slack link * docs: fix ExecuteHook* examples Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Alex Johnson <[email protected]>
Closes #3069
Addition of documentation for plugins under
Knowledge Base
Includes docs for plugin defined hooks which is tracked in: #3038