Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove pkg/openapiconsole import in scaffolded chain #3337

Merged
merged 14 commits into from
Dec 26, 2022
Merged

refactor: remove pkg/openapiconsole import in scaffolded chain #3337

merged 14 commits into from
Dec 26, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Dec 21, 2022

Closes #3336

@tbruyelle
Copy link
Contributor

@aljo242 I ran gofmt on the modified plush files, there was a bunch of format fixes to do. See 3f08aa9

@aljo242
Copy link
Contributor Author

aljo242 commented Dec 23, 2022

@tbruyelle do you think index.tpl should be moved to the static directory?

@tbruyelle
Copy link
Contributor

@tbruyelle do you think index.tpl should be moved to the static directory?

Looks better in static yes!

@aljo242
Copy link
Contributor Author

aljo242 commented Dec 23, 2022

@tbruyelle do you think index.tpl should be moved to the static directory?

Looks better in static yes!

Ended up adding it in template directory since we use http/template to generate the actual file.

@aljo242 aljo242 merged commit e2cc76c into main Dec 26, 2022
@aljo242 aljo242 deleted the refactor/openapi branch December 26, 2022 20:13
RaulBernal
RaulBernal reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@RaulBernal RaulBernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last 3 lines has slipped in

ignite/templates/app/files/docs/template/index.tpl
</script>
</body>
</html>
Footer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this 3 lines has slipped in

Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@tbruyelle
refactor: remove pkg/openapiconsole import in scaffolded chain (ign…
f4ac2f1 
…ite#3337)

* fix typo

* add nodeservice

* add nodeservice

* add doc

* remove need for openAPI import

* no more import

* no more import

* changelog

* gofmt on go.plush files

* update changelog

* refactor

Co-authored-by: Thomas Bruyelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaulBernal RaulBernal RaulBernal left review comments

@tbruyelle tbruyelle tbruyelle approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pkg/openapiconsole import from scaffolded chains.
4 participants
@aljo242 @tbruyelle @jeronimoalbi @RaulBernal