fix: state error and info are now displayed when using serve UI #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
added
type:error
jeronimoalbi
requested review from
lumtis,
aljo242,
tbruyelle,
fadeev and
Pantani
as code owners
aljo242
previously approved these changes
Jan 7, 2023
aljo242
approved these changes
Jan 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
=======================================
Coverage 23.44% 23.44%
=======================================
Files 298 298
Lines 23496 23496
=======================================
Hits 5509 5509
Misses 17490 17490
Partials 497 497
|
tbruyelle
approved these changes
Jan 9, 2023
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…te#3383) * fix: state error and info are now displayed when using serve UI * chore: update changelog Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the chain serve state error to include context information:
Without these changes
chain servewould only print the error without the context information when the UI is enabled: