chore: add back crisis module to SetOrderBeginBlockers #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module must be added to avoid triggering an assertion that requires that all modules are added to `SetOrderBeginBlockers` even if they don't implement `HasBeginBlocker`. Modules that don't implement it can be removed once Cosmos SDK v0.50.0 is released.
jeronimoalbi
added
skip-changelog
Pantani
approved these changes
Jul 26, 2023
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* chore: add back crisis module to SetOrderBeginBlockers The module must be added to avoid triggering an assertion that requires that all modules are added to `SetOrderBeginBlockers` even if they don't implement `HasBeginBlocker`. Modules that don't implement it can be removed once Cosmos SDK v0.50.0 is released. * chore: remove deprecated changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module must be added to avoid triggering an assertion that requires that all modules are added to
SetOrderBeginBlockerseven if they don't implementHasBeginBlocker. Modules that don't implement it can be removed from the list once Cosmos SDKv0.50.0is released.