Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct TS code generation to generate paginated fields #3808

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: correct TS code generation to generate paginated fields #3808

merged 2 commits into from
Dec 5, 2023

Conversation

jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Dec 5, 2023 •
edited
Loading

Closes #3809

@jeronimoalbi jeronimoalbi added type:error Something isn't working component:ts-client component:code-gen Related to code generation labels Dec 5, 2023
@jeronimoalbi jeronimoalbi self-assigned this Dec 5, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:packages labels Dec 5, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Merging #3808 (a9d41d8) into main (70e787f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3808   +/-   ##
=======================================
  Coverage   24.21%   24.22%           
=======================================
  Files         292      292           
  Lines       24495    24496    +1     
=======================================
+ Hits         5932     5933    +1     
  Misses      18024    18024           
  Partials      539      539
Files Coverage Δ
ignite/pkg/cosmosanalysis/module/module.go 61.15% <100.00%> (+0.16%) ⬆️

@jeronimoalbi
Copy link
Member Author

@clockworkgr this PR should fix the issue with the missing pagination support when Vue composables are generated

@ilgooz ilgooz merged commit 9aa965c into main Dec 5, 2023
42 checks passed
@ilgooz ilgooz deleted the fix/tsclient-vue-generate-pagination branch December 5, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clockworkgr clockworkgr Awaiting requested review from clockworkgr

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:code-gen Related to code generation component:configs component:packages component:ts-client type:error Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TS code generation to support pagination
2 participants
@jeronimoalbi @ilgooz