Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove gRPC info from Ignite Apps errors #3830

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

jeronimoalbi
Copy link
Member

Removes extra gRPC information from Ignite App errors to have consistent CLI error messages

@jeronimoalbi jeronimoalbi added component:apps Related to Ignite Apps. component:cmd type:enh Improvement or update to existing feature(s). labels Dec 8, 2023
@jeronimoalbi jeronimoalbi self-assigned this Dec 8, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Dec 8, 2023
@jeronimoalbi jeronimoalbi marked this pull request as ready for review December 8, 2023 11:42
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Pantani Pantani merged commit e4c6d85 into main Dec 8, 2023
44 checks passed
@Pantani Pantani deleted the feat/handle-apps-grpc-errors branch December 8, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:apps Related to Ignite Apps. component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:enh Improvement or update to existing feature(s).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants