feat: Improve app scaffolding #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehsan-saradar
added
component:scaffold
Ehsan-saradar
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Ehsan-saradar
force-pushed
the
feat/improve-app-scaffolding
branch
from
14af2d4 to
6dbf753
Compare
Ehsan-saradar
force-pushed
the
feat/improve-app-scaffolding
branch
from
b466dbf to
c3f3871
Compare
Pantani
reviewed
Dec 15, 2023
julienrbrt
reviewed
Dec 15, 2023
ignite/services/plugin/template/integration/integration_test.go.plush
Outdated
Show resolved
Hide resolved
Ehsan-saradar
requested review from
jeronimoalbi,
Cplus13,
salmad3,
julienrbrt and
Pantani
salmad3
previously approved these changes
Jan 20, 2024
Ehsan-saradar
dismissed stale reviews from salmad3 and julienrbrt
via
79f2474
julienrbrt
previously approved these changes
Jan 22, 2024
|
There a a couple of comments to be resolved but other than that looks good 👍 |
Pantani
previously approved these changes
Jan 26, 2024
Pantani
previously approved these changes
Jan 29, 2024
Pantani
reviewed
Jan 29, 2024
Pantani
approved these changes
Jan 29, 2024
julienrbrt
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3828
This PR:
ignite app scaffold.Adds acmdpackage to structure of app source code forcobracommands and sub commands.integrationpackage for integration unit tests.app.ignite.ymlfile at the root of project which will give some informations about the app(s) in the repository to the marketplace app.