feat: Better names for map/list query endpoints #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehsan-saradar
added
the
component:scaffold
github-actions
bot
added
component:ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3962 +/- ##
==========================================
- Coverage 24.79% 24.79% -0.01%
==========================================
Files 296 296
Lines 24904 24907 +3
==========================================
Hits 6176 6176
- Misses 18161 18164 +3
Partials 567 567
|
Ehsan-saradar
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
julienrbrt
previously approved these changes
Feb 13, 2024
...tes/typed/map/files/tests/component/x/{{moduleName}}/keeper/query_{{typeName}}_test.go.plush
Outdated
Show resolved
Hide resolved
jeronimoalbi
approved these changes
Feb 14, 2024
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* Move query methods to queryServer struct * Rename show-x queries to get-x * Fix map queries bug * Update changelog * More descriptive changelog * Fix singleton cli bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3318
This PR moves the query RPC server implementation from
Keeperstruct to a separate dedicated structqueryServerwhich helps us negate the possible conflicts betweenKeeperand query endpoints method names. It also renames theshow-xcli command formap/listtypes toget-xand renames the<%= TypeName.UpperCamel %>query toGet<%= TypeName.UpperCamel %>and<%= TypeName.UpperCamel %>AlltoList<%= TypeName.UpperCamel %>so we get consistent names for both cli and RPC.