Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add chain lint command #3977

Merged
merged 4 commits into from
Feb 19, 2024
Merged

feat(cmd): add chain lint command #3977

merged 4 commits into from
Feb 19, 2024

Conversation

julienrbrt
Copy link
Member

Closes: #3288

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. labels Feb 19, 2024
Pantani
Pantani approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also create the chain format and chain govet

@julienrbrt julienrbrt merged commit bf0b66e into main Feb 19, 2024
43 of 44 checks passed
@julienrbrt julienrbrt deleted the julien/lint branch February 19, 2024 21:12
@julienrbrt
Copy link
Member Author

we can also create the chain format and chain govet

I agree about the format command, but govet isn't really useful as it's already a linter in golangci-lint.

julienrbrt added a commit that referenced this pull request May 29, 2024
@julienrbrt
feat(cmd): add chain lint command (#3977)
e96cf83 
* feat(cmd): add `chain lint` command

* pr number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:templates type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add linter to scaffolded tools
2 participants
@julienrbrt @Pantani