Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blog): fix pointer type and add build steps #4412

Merged
merged 3 commits into from
Nov 20, 2024
Merged

docs(blog): fix pointer type and add build steps #4412

merged 3 commits into from
Nov 20, 2024

Conversation

chen4903
Copy link
Contributor

@chen4903 chen4903 commented Nov 19, 2024 •
edited
Loading

  • Correct the error: The Post in &types.QueryShowPostResponse is a pointer type Post *Post
  • Add a build statement before starting the blockchain; otherwise, the code will throw an error, which might confuse readers.
  • fix comment: bei => by

@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:configs labels Nov 19, 2024
@chen4903 chen4903 changed the title docs(fix error and add more details) docs(blog): fix pointer type and add build steps Nov 19, 2024
julienrbrt
julienrbrt approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thank you!

@julienrbrt julienrbrt merged commit 11efdfb into ignite:main Nov 20, 2024
11 of 12 checks passed
@chen4903 chen4903 deleted the fix-blog branch November 26, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@chen4903 chen4903

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:docs Documentation additions or improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chen4903 @julienrbrt