Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): loading state shows up when switching between tabs (assets) #204

Closed
fadeev opened this issue Feb 17, 2022 · 2 comments · Fixed by #237
Closed

fix(ui): loading state shows up when switching between tabs (assets) #204

fadeev opened this issue Feb 17, 2022 · 2 comments · Fixed by #237
Assignees
@mihailmarcu

Comments

@fadeev
Copy link
Contributor

fadeev commented Feb 17, 2022

To reproduce:

  • sign in with an account
  • click on the "Data" tab
  • click on the "Portfolio" tab

Screenshot 2022-02-17 at 14 32 00
@fadeev fadeev changed the title Assets: loading state shows up when switching between tabs fix(ui): loading state shows up when switching between tabs (assets) Feb 19, 2022
@fadeev fadeev mentioned this issue Feb 21, 2022
Closed
@mihailmarcu mihailmarcu self-assigned this Feb 22, 2022
@mihailmarcu mihailmarcu added enhancement Improvement over existing feature and removed enhancement Improvement over existing feature labels Feb 22, 2022
@mihailmarcu
Copy link
Contributor

@fadeev, @marinhoarthur,
Is this issue related to what we discussed regarding reloading components when changing a router? I wonder if solution can be in one task. Wdyt?

mihailmarcu added a commit that referenced this issue Feb 22, 2022
@mihailmarcu
#204: Implementation of the unsubscribe functionality onUnmounted
ce30f78
@mihailmarcu mihailmarcu mentioned this issue Feb 22, 2022
Merged
mihailmarcu added a commit that referenced this issue Feb 23, 2022
@mihailmarcu
#204: Remove loading on tabs switch
e65c0fa
@marinhoarthur
Copy link
Contributor

For now let's fix skeleton-forever. Soon enough we will be refactoring overall fetching of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihailmarcu mihailmarcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: skeleton forever ignite/web
3 participants
@fadeev @marinhoarthur @mihailmarcu