Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make links customisable (navbar/dropdown) #223

Open
fadeev opened this issue Feb 19, 2022 · 1 comment
Open

feat: make links customisable (navbar/dropdown) #223

fadeev opened this issue Feb 19, 2022 · 1 comment
Assignees
@mihailmarcu
Labels
feature-request A new feature implementation is wished

Comments

@fadeev
Copy link
Contributor

fadeev commented Feb 19, 2022

Right now items in the dropdown are not links. We need to make the dropdown customizable by our users.

Screenshot 2022-02-19 at 18 37 24

Before implementing, propose the solution below. Probably, it's going to be a prop that a dev can set and we have it set by default to Starport websites/twitter in the template.
@marinhoarthur marinhoarthur added the feature-request A new feature implementation is wished label Mar 9, 2022
@mihailmarcu mihailmarcu self-assigned this Mar 10, 2022
@mihailmarcu
Copy link
Contributor

Hey @fadee, @marinhoarthur,
As you already know, our component is not completely abstract and scalable to be customizable and reusable. I found a solution, and as already discussed, I will initiate a discussion about this solution.

App vue

SpNavbar vue

SpAcc vue

SpAccDropdown vue

This is already a working solution as I have implemented and tested it locally.

mihailmarcu added a commit that referenced this issue Mar 11, 2022
@mihailmarcu
#223: Add solution for customization of the external links
455bb45
@mihailmarcu mihailmarcu mentioned this issue Mar 11, 2022
Closed
mihailmarcu added a commit that referenced this issue Mar 18, 2022
@mihailmarcu
#223: Add new component for account external link
ef76fd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihailmarcu mihailmarcu

Labels
feature-request A new feature implementation is wished
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add solution for customization of the external links ignite/web
3 participants
@fadeev @marinhoarthur @mihailmarcu