SPIFFS submodule and fixed build for both platforms #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
me-no-dev
commented
Oct 8, 2017
me-no-dev
commented
- use submodule instead of copies of the SPIFFS source
- move config to it's own folder
- update Makefile to work with the new file structure
- fix build defines for ESP8266 and ESP32 (tested with OSX on both targets)
|
@igrr this is good to go :) |
igrr
approved these changes
Oct 11, 2017
| @@ -127,9 +99,7 @@ typedef uint8_t u8_t; | |||
| #endif | |||
|
|
|||
| // Define maximum number of gc runs to perform to reach desired free pages. | |||
| #ifndef SPIFFS_GC_MAX_RUNS | |||
| #define SPIFFS_GC_MAX_RUNS 5 | |||
| #endif | |||
There was a problem hiding this comment.
Do the removals of ifndef..endif guards come from the upstream config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.