Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/iiab/iiab/issues/3487 workarounds #536

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

tim-moody
Copy link
Contributor

No description provided.

@tim-moody
Copy link
Contributor Author

passed smoke test
passed unit tests
trying various general tests

@holta
Copy link
Member

holta commented Apr 18, 2023

@tim-moody is there some way we can mandate (or strongly encourage) feedback... to collect more examples of corrupt menu.json files as they arise + context when this happens?

(Perhaps UX can ask people to run iiab-diagnostics at the bare minimum + ask them to post the resulting sprunge.us URL?)

@tim-moody tim-moody merged commit 0e59715 into iiab:master Apr 18, 2023
@tim-moody
Copy link
Contributor Author

Test Plan:

  • Access Home Page
  • In Adm Cons Content Menus -> Edit Content Menus Load Menu
  • In Adm Cons Content Menus Click Update Home Menu

Do these actions for each of following versions of /library/www/html/home/menu.json:

  • Presumed OK
  • Misspelled location like homex
  • cp of /opt/iiab/iiab-admin-console/test-files/patchable-menu.json
  • cp of /opt/iiab/iiab-admin-console/test-files/broken-menu.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants