Update blueprints #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
update-blueprints-addon
branch
from
73e64fb to
f04f1a4
Compare
ijlee2
commented
Aug 20, 2024
Comment on lines
+99
to
+102
| 'glimmer-loose', | ||
| 'glimmer-strict', | ||
| 'template-only-loose', | ||
| 'template-only-strict', |
There was a problem hiding this comment.
The names loose and strict came from emberjs/ember.js#20511.
ijlee2
force-pushed
the
update-blueprints-addon
branch
from
f04f1a4 to
ac66209
Compare
ijlee2
commented
Aug 20, 2024
Comment on lines
+1
to
+3
| <div> | ||
| {{yield}} | ||
| </div> |
There was a problem hiding this comment.
I added a <div> container to match the other blueprints and to avoid a linting error from no-yield-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
README'sgenerate component