Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm neon port #203

Merged
merged 6 commits into from
Sep 29, 2021
Merged

Arm neon port #203

merged 6 commits into from
Sep 29, 2021

Conversation

phlash
Copy link
Contributor

@phlash phlash commented Jul 1, 2021

Hi ExtIO_sddc maintainers, I had an interest in running this on Linux / ARM (RaspberryPi, OrangePi, etc.) as a downsampling head-end, so have made the necessary adjustments to the build and added a Neon-optimised R2IQ implementation.

There are also a few changes to the (out-of-date / incompatible) unittest/core_test.cpp file, as I based my work on v1.2.0 tagged build (I found that current version fails to pass unit tests on x86, crashing with a pointer problem, hence starting with last stable). Not sure what you would like to do here, please let me know?

@ik1xpv
Copy link
Owner

ik1xpv commented Jul 2, 2021

Hi Phlash, thank you. I appreciate your input. My programming skills are limited and I have no experience with Linux and Arm. Howard's, Hayati's, Franco's ideas and coding made it possible to get here.
My activity is reduced in Summer, when I am a full time grandfather :-)

@phlash
Copy link
Contributor Author

phlash commented Jul 2, 2021

Congratulations on grandfather-hood, always a priority 😄

I'm happy to wait for @howard0su, @hayguen or @fventuri to respond, while I continue into real hardware and testing!

Copy link
Collaborator

@howard0su howard0su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except wisdom files. Not sure if we want to commit into repo. My understanding is that the files are changed for different hardware.

unittest/core_test.cpp Outdated Show resolved Hide resolved
wisdom-arm Outdated Show resolved Hide resolved
@phlash
Copy link
Contributor Author

phlash commented Jul 12, 2021

Looks good to me except wisdom files. Not sure if we want to commit into repo. My understanding is that the files are changed for different hardware.

Thanks, this is true, I was simply saving them as it takes several minutes to generate on my wee ARM board. I'll pop a pattern in .gitignore and remove these from the PR.

@howard0su
Copy link
Collaborator

Can you resolve the conflict of unittest? then we can merge.

@phlash
Copy link
Contributor Author

phlash commented Jul 15, 2021

Can you resolve the conflict of unittest? then we can merge.

This should be good to merge now, although I am still unable to run unittest due to the segfault somewhere in R2IQ_impl I mentioned at the start. Would you like me to raise a new issue for that?

@howard0su howard0su merged commit 641331c into ik1xpv:master Sep 29, 2021
@phlash phlash deleted the arm-neon branch October 1, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants