Implement zerocopy writes for the encrypted protocol #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.12+ and later `transport.writelines` is implemented as [`sendmsg(..., IOV_MAX)`](python/cpython#91166) which allows us to avoid joining the bytes and sending them in one go. Older Python will effectively do the same thing we do now `b"".join(...)`
|
@ikalchev When you get a chance, I have a few PRs in the queue |
|
Awesome stuff! 🙏 |
ikalchev
added a commit
that referenced
this pull request
Nov 3, 2024
* Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag * Increase idle connection check interval to 300s (#475) This check was creating a lot of TimerHandles when the user had multiple bridges. We do not need to check very often as connections usually stay around for 24+hours * Implement zerocopy writes for the encrypted protocol (#476) * Implement zerocopy writes for the encrypted protocol With Python 3.12+ and later `transport.writelines` is implemented as [`sendmsg(..., IOV_MAX)`](python/cpython#91166) which allows us to avoid joining the bytes and sending them in one go. Older Python will effectively do the same thing we do now `b"".join(...)` * update tests * Revert "Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag" (#477) * Avoid os.chmod failing on Windows if file non-existant (#471) * Avoid os.chmod failing on Windows if file non-existant * Update accessory_driver.py --------- Co-authored-by: Ivan Kalchev <[email protected]> * Fix mdns tests (#478) * Fix pylint complaints (#480) * Address remaining pylint complaints (#481) * Address remaining pylint complaints * Address remaining pylint complaints * v4.9.2 --------- Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Perry Kundert <[email protected]> Co-authored-by: Ivan Kalchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.12+ and later
transport.writelinesis implemented assendmsg(..., IOV_MAX)which allows us to avoid joining the bytes and sending them in one go.Older Python will effectively do the same thing we do now
b"".join(...)