Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stb's paeth predictor #540

Closed
wants to merge 1 commit into from
Closed

Use stb's paeth predictor #540

wants to merge 1 commit into from

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Dec 1, 2024

The stb's implementation doesn't seem to be always faster.

For me on Apple M3 it's faster for 1, 6, and 8-byte pixels. About the same for 4. Half the speed for 2 and 3. I'm curious if that's universal across platforms. On a Ryzen most are faster, except 6 Bpp.

Bpp 1 2 3 4 6 8
Apple M3 y N N = y y
Ryzen 5 5600X y y y y N y

I've used cargo +nightly bench -Fbenchmarks Paeth --bench unfilter -- --save-baseline=…

@fintelia
Copy link
Contributor

fintelia commented Dec 2, 2024

Thanks for the measurements! I've incidentally also got a 5600X, so I can't offer any further data points

@HeroicKatora
Copy link
Member

Thanks for the comparative measurements, can be closed with #539 as implemented and constrained to arch x86.

@kornelski kornelski deleted the stb-paeth branch December 8, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants