Add BufRead + Seek bound on many decoders #2149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to allow future decoder improvements:
BufRead
implementation rather than just aRead
implementation can be faster.Seek
bound is useful for decreasing the memory usage of the decoder. Instead of storing all image metadata as it is seen, a decoder can record the location in the file of specific chunks and then seek to them if/when they are queried.At the same time, not all decoders are likely to need either of these and having looser trait bounds is nicer for users. Thus I left the existing
Read
bound for some decoders (and actually removed theSeek
bound on TGA). After this change, the trait bounds are: