-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples #25
Add examples #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions.
I have some doubts on the API of pyffs/conv.py
, but let's go with this for now.
|
||
fname = pathlib.Path(__file__).resolve().parent / "profile_ffsn_2d.png" | ||
fig.savefig(fname, dpi=300) | ||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig.show()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it's my matplotlib settings, but fig.show()
doesn't generate a pop-up window with the figure, while plt.show()
does.
|
||
fname = pathlib.Path(__file__).resolve().parent / "profile_ffs.png" | ||
fig.savefig(fname, dpi=300) | ||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig.show()
fig.tight_layout() | ||
fig.savefig(os.path.join(fig_path, "profile_convolve2d.png")) | ||
|
||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig.show()
fig.tight_layout() | ||
fig.savefig(os.path.join(fig_path, "bandlimited_interp2d_vary_width.png")) | ||
|
||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig.show()
@@ -0,0 +1,151 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as examples/interp_1d.py
.
plt.tight_layout() | ||
plt.savefig(os.path.join(fig_path, "convolve_1d.png")) | ||
|
||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig vs plt.
@@ -0,0 +1,150 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fig vs plt
Will be useful for paper. I've also added some convolution examples and functions, I know this is a point to discuss as @SepandKashani wanted to keep it separate, but I think it might be useful to show such examples in the package so people have something to get inspiration from. Maybe the convolution functions can be moved into the example script rather than in the package?