Camera Shot System #1010
Merged
Camera Shot System #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is take 2 for this.
So after more investigation I figured out that all the math was correct.
The issue is that it's impossible to recreate some shots when you consider the actor rotation as the camera can't go over the head or under the legs fully (if you were flat in the world, the restriction is in world space).
The approach I have taken this time is to just assume the character is always flat on the ground (so we only consider the direction they are facing in one plane).
This way, you will get the overall camera relative to the actor, and you just need to load a pose on them that includes the other rotations and then they will be framed correctly.
I think overall this is a good compromise as it gets you 100% of what you want in most cases, and 99% of the way in the few cases where the actual actor is rotated forward/backward or side/side in the world.