Eorzea Time Control #717
Merged
Eorzea Time Control #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another good one! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches Time Control back to using/modifying Eorzea Time. This means that things like the music, as well as the time when entering gpose, are correct for the set time of day. Basically it behaves like it did before Endwalker from a user perspective and that seems to be what people want/expect.
Basically the approach I took here was to find out where the game writes the time to the well known Eorzea Time location and patch out that mov/copy when time control is enabled so we can control it directly.
Like with my last PR, these are fresh sigs and offsets so I've ensured they run across multiple process launches for me but some Alpha testing to verify it works for everyone as well as ensuring it doesn't impact something I didn't think to check would be good.
One other note, when developing this I discovered the offset for gpose time. I haven't hooked into it because there is some weirdness that it must be 0 outside of gpose so it'd have to track when it's set, when to clear it and all that and it seems unnecessary as setting time directly in gpose has never been supported without unchecking. However, I thought this might be useful for Scenes or similar where it's a one time set, so left a comment with the offset.