Allow for URI with spaces to be opened & fix empty local gallery crash #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2021
Closed
|
looks good! thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added check for case where gallery is loaded but empty which previously would cause a crash, most likely a more robust check is possible but this does the job without any bigger pieces of code or major rewrites.
Also modified the way images from local gallery are being opened, previous approach would not respect URI with spaces, this approach allows it as it adds quotes around URI (first quotes have to be empty since if we use quotes with start command it expects first quotes to have command prompt window name)