Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate minWidth, maxWidth, widthTolerance #257

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix: validate minWidth, maxWidth, widthTolerance #257

merged 1 commit into from
Mar 16, 2021

Conversation

ericdeansanchez
Copy link
Contributor

No description provided.

@ericdeansanchez ericdeansanchez requested a review from a team as a code owner March 10, 2021 19:21
@commit-lint
Copy link

commit-lint bot commented Mar 10, 2021

Bug Fixes

  • validate minWidth, maxWidth, widthTolerance (30cbf37)

Contributors

ericdeansanchez

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ericdeansanchez ericdeansanchez mentioned this pull request Mar 10, 2021
Closed
frederickfogerty
frederickfogerty approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Tests could be improved a little bit but looks good!

test/test-buildSrcSet.mjs Show resolved Hide resolved
@ericdeansanchez ericdeansanchez merged commit f65b23e into main Mar 16, 2021
@ericdeansanchez ericdeansanchez deleted the validate-targetWidths branch March 16, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherwinski sherwinski sherwinski approved these changes

@frederickfogerty frederickfogerty frederickfogerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericdeansanchez @frederickfogerty @sherwinski